Login |  Register |  FAQ
   
Post new topic Reply to topic  [ 1416 posts ]  Go to page Previous  1 ... 91, 92, 93, 94, 95

Armyforge Update (Online EA Force Creator)

 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Wed Feb 17, 2021 7:25 pm 
Brood Brother
Brood Brother

Joined: Tue Feb 22, 2011 11:43 pm
Posts: 2535
Location: UK
Abetillo wrote:
I have checked the .json files on the Github and the code does not seem complicated, at least for adding and modifying things.

I think i have read here that people sends you files with the lists to add but i do not know the details or anything else on how it works.

PM me if i can be of any help.

Submissions can be processed using github, collaboration on code is what it's designed for after all. The files to change are in:
https://github.com/adam77/snapfire/tree ... /war/lists
Just fork the repo, modify and test your changes and create a pull request. Github has instructions for how to use forks, pull requests, branching etc.

I am not sure who other than kyuss and adam77 can approve pull requests but I am happy to also do this if they want to give me access, all it takes is to check the changes against the official source and build them locally to check they work.

New lists are a lot more work than changing something that exists, but I think there might still be some IG changes that didnt make their way through all the variant lists.

_________________
Kyrt's Battle Result Tracker (forum post is here)
Kyrt's trade list


Top
 Profile Send private message  
 
 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Wed Feb 17, 2021 7:28 pm 
Brood Brother
Brood Brother

Joined: Tue Feb 22, 2011 11:43 pm
Posts: 2535
Location: UK
Abetillo wrote:
Thanks to both Kyuss and Adam for the effort.

Unfortunately, i come to you with some work about something i do not see what is wrong with it. If i make any list with NetEA Saim-Hann, save the link, and use it again to load the list, i am greeted with an small window on top telling me ''Sorry, there was an error loading the army.'' and redirects me to it with just the name i added on top when i put one on it.
I have tested with different browsers and on both mobile and laptop and got the same. Tried to reduce the URL to the minimum and add different formations and the only thing that gets past is the name we can add for the list.

This has not happened to me with any other list and i see no mention on this thread of it.


I will see if I can have a look myself; in the meantime you should be able to tell which part of the list is at fault by checking the console in Chrome developer tools (or equivalent in other browsers). This assumes you have some programming experience to interpret it though.

_________________
Kyrt's Battle Result Tracker (forum post is here)
Kyrt's trade list


Top
 Profile Send private message  
 
 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Wed Feb 17, 2021 8:30 pm 
Brood Brother
Brood Brother

Joined: Tue Feb 22, 2011 11:43 pm
Posts: 2535
Location: UK
OK I looked at the issue, it is because the loader expects that formation IDs are >= 500 and everything else is an upgrade. All the formation IDs for this list are < 500 so it tries to load them as upgrades. You would only find this issue with the list when loading, as the constraint on formation IDs doesnt exist anywhere else.

You can fix it for yourself by fixing all the formation IDs (a bit of a pain as you have to change all references to them in upgradeConstraints and formationConstraints). Though I will submit a PR to improve the code to not make this assumption. You can check my version out locally if you want:
https://github.com/andyjenkinson/snapfi ... mation-ids

_________________
Kyrt's Battle Result Tracker (forum post is here)
Kyrt's trade list


Top
 Profile Send private message  
 
 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Thu Feb 18, 2021 11:57 am 
Brood Brother
Brood Brother
User avatar

Joined: Mon Aug 31, 2015 4:24 pm
Posts: 336
Location: Galicia
Kyrt wrote:
Submissions can be processed using github, collaboration on code is what it's designed for after all. The files to change are in:
https://github.com/adam77/snapfire/tree ... /war/lists
Just fork the repo, modify and test your changes and create a pull request. Github has instructions for how to use forks, pull requests, branching etc.


Ok, thank you, i will check around. I am more familiar with leeching from Github than at working with it but seems doable.

Kyrt wrote:
OK I looked at the issue, it is because the loader expects that formation IDs are >= 500 and everything else is an upgrade. All the formation IDs for this list are < 500 so it tries to load them as upgrades. You would only find this issue with the list when loading, as the constraint on formation IDs doesnt exist anywhere else.

You can fix it for yourself by fixing all the formation IDs (a bit of a pain as you have to change all references to them in upgradeConstraints and formationConstraints). Though I will submit a PR to improve the code to not make this assumption. You can check my version out locally if you want:
https://github.com/andyjenkinson/snapfi ... mation-ids


Thanks.

::) I gave up too easily thinking it could be anywhere in the code, not only on the list's. After i read this i found it in less than a minute, and noticed also other things about how it works.

I will see what i can do about doing it myself. I suppose that i will need to use new IDs but as from what i see by checking other lists they do not need to be unique to Saim-Hann so at least i won't need to investigate on the others.

_________________
Sculpting Orks thread
Statistics of games for OGBM v.3 list


Top
 Profile Send private message  
 
 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Fri Feb 19, 2021 12:04 am 
Brood Brother
Brood Brother

Joined: Tue Feb 22, 2011 11:43 pm
Posts: 2535
Location: UK
kyussinchains has kindly merged the pull request already so this is now be fixed in the live version:
https://adam77.github.io/snapfire/war/c ... ~15x1~10x9

Thanks for the report. Please feel free to contribute updates to track any list changes or fixes you come across.

_________________
Kyrt's Battle Result Tracker (forum post is here)
Kyrt's trade list


Top
 Profile Send private message  
 
 Post subject: Re: Armyforge Update (Online EA Force Creator)
PostPosted: Mon Feb 22, 2021 1:03 am 
Brood Brother
Brood Brother
User avatar

Joined: Sat Jan 04, 2020 10:10 pm
Posts: 8
NetEA Steel legion fails to open for me. Blind guess would be that data JSON is not a JSON. I'm not a JS guy. Please check.
https://github.com/adam77/snapfire/pull/221

_________________
Die for the Emperor or die trying


Top
 Profile Send private message  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 1416 posts ]  Go to page Previous  1 ... 91, 92, 93, 94, 95


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  

cron

Powered by phpBB ® Forum Software © phpBB Group
CoDFaction Style by Daniel St. Jules of Gamexe.net